feat(TimeTableViz): sort by first metric

[serenajiang]

SUMMARY

Sort TimeTableViz (time series table) by the first metric descending. Currently, no sorting is applied, so time series tables show the "first" n series, which can be confusing to users and isn't very helpful. Sorting by the first metric descending is more consistent with other chart types.

Note time series tables do not have a sort by control - might be better to add this in the future, but this should still an improvement for now.

TESTING INSTRUCTIONS

Create time series viz. Confirm that an order by clause exists in the query.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

@john-bodley @ktmud ?

[etr2460]

any way we can add a test for this?

[codecov]

Codecov Report

Merging #18896 (0ff7468) into master (cdd4fa5) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #18896      +/-   ##
==========================================
+ Coverage   66.21%   66.41%   +0.20%     
==========================================
  Files        1633     1640       +7     
  Lines       63210    63478     +268     
  Branches     6409     6409              
==========================================
+ Hits        41852    42159     +307     
+ Misses      19698    19659      -39     
  Partials     1660     1660              

Flag	Coverage Δ
hive	52.60% <0.00%> (+0.31%)	⬆️
mysql	81.83% <100.00%> (+0.28%)	⬆️
postgres	81.88% <100.00%> (+0.28%)	⬆️
presto	52.44% <0.00%> (+0.31%)	⬆️
python	82.31% <100.00%> (+0.27%)	⬆️
sqlite	81.57% <100.00%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/viz.py	58.26% <100.00%> (+0.12%)	⬆️
superset/datasets/commands/create.py	98.11% <0.00%> (-1.89%)	⬇️
superset/views/utils.py	82.20% <0.00%> (ø)
superset/views/database/forms.py	94.44% <0.00%> (ø)
superset/columns/models.py	100.00% <0.00%> (ø)
superset/users/api.py	100.00% <0.00%> (ø)
superset/users/schemas.py	100.00% <0.00%> (ø)
superset/tables/models.py	100.00% <0.00%> (ø)
superset/datasets/models.py	100.00% <0.00%> (ø)
superset/tables/schemas.py	100.00% <0.00%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd4fa5...0ff7468. Read the comment docs.

[etr2460]

lgtm, thanks for the test!