Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add intersect method from backend to fontend for upload extensions #18811

Merged
merged 9 commits into from
Feb 25, 2022
Merged

chore: add intersect method from backend to fontend for upload extensions #18811

merged 9 commits into from
Feb 25, 2022

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr move the intersect logic from the api to the frontend as we begin to move nav logic out of fab.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 23, 2022 •
edited
Loading

Codecov Report

Merging #18811 (a90e811) into master (420a63f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a90e811 differs from pull request most recent head 284a7e2. Consider uploading reports for the commit 284a7e2 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18811   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files        1640     1640           
  Lines       63507    63509    +2     
  Branches     6415     6417    +2     
=======================================
+ Hits        42165    42167    +2     
  Misses      19681    19681           
  Partials     1661     1661
Flag Coverage Δ
javascript 51.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/components/Menu.tsx 56.41% <ø> (ø)
superset-frontend/src/views/CRUD/utils.tsx 65.25% <100.00%> (+1.53%) ⬆️
...perset-frontend/src/views/components/MenuRight.tsx 72.13% <100.00%> (ø)
superset/views/base.py 74.83% <100.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420a63f...284a7e2. Read the comment docs.

hughhhh
hughhhh reviewed Feb 24, 2022
View reviewed changes
superset-frontend/src/views/components/MenuRight.tsx Outdated
@@ -107,6 +105,13 @@ const StyledAnchor = styled.a`

const { SubMenu } = Menu;

interface ExtentionConfigs {
CSV_EXTENSIONS: Array<any>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be boolean

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No these are for what are coming back from the backend configs which are arrays of extension types.

eschutho
eschutho approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @pkdotson. I think @hughhhh may have made some changes that will have conflicts in your file, just fyi.

@pkdotson pkdotson merged commit 8d38675 into apache:master Feb 25, 2022
sadpandajoe added a commit to preset-io/superset that referenced this pull request Mar 7, 2022
@sadpandajoe
Revert "chore: add intersect method from backend to fontend for uploa…
5d51371 
…d extensions (apache#18811)"

This reverts commit 8d38675.
hughhhh added a commit to preset-io/superset that referenced this pull request Mar 7, 2022
@hughhhh
Revert "chore: add intersect method from backend to fontend for uploa…
b384a2f 
…d extensions (apache#18811)"

This reverts commit 8d38675.
villebro pushed a commit that referenced this pull request Apr 3, 2022
@pkdotson @villebro
chore: add intersect method from backend to fontend for upload extens…
e20788c 
…ions (#18811)

* chore: add intersect method from be to font end

* fix lint

* add suggestion

* fix python test

* run precommit

* fix pytlint

* update changes from masters

(cherry picked from commit 8d38675)
@mistercrunch mistercrunch added 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

@AAfghahi AAfghahi AAfghahi approved these changes

@lyndsiWilliams lyndsiWilliams Awaiting requested review from lyndsiWilliams

@hughhhh hughhhh Awaiting requested review from hughhhh

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pkdotson @eschutho @hughhhh @AAfghahi @mistercrunch @villebro