Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Explore): Annotation cache should be ignore when adding new / updated annotation #18788

Merged
merged 1 commit into from
Feb 21, 2022
Merged

fix(Explore): Annotation cache should be ignore when adding new / updated annotation #18788

merged 1 commit into from
Feb 21, 2022

Conversation

geido
Copy link
Member

@geido geido commented Feb 17, 2022

SUMMARY

This PR fixes an issue for which the annotations were using the cached data when adding or updating them. The problem happened because the refreshAnnotationData wasn't using the force cache parameter.

BEFORE

DEV.Games.per.Genre.over.time.1.mp4

AFTER

DEV.Games.per.Genre.over.time.mp4

TESTING INSTRUCTIONS

  1. Open a Chart
  2. Add annotations
  3. Make sure the annotations are the most updated

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #18788 (b54fb05) into master (30a9d14) will not change coverage.
The diff coverage is 0.00%.

❗ Current head b54fb05 differs from pull request most recent head 6f618ff. Consider uploading reports for the commit 6f618ff to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18788   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files        1620     1620           
  Lines       63087    63087           
  Branches     6372     6372           
=======================================
  Hits        41840    41840           
  Misses      19590    19590           
  Partials     1657     1657           
Flag Coverage Δ
javascript 51.25% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/chartAction.js 53.79% <ø> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx 10.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a9d14...6f618ff. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix and general cleanup here!

@geido geido merged commit 5356343 into apache:master Feb 21, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants