Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing temporary_superset_ui folder (no longer needed) #18706

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

This directory is a vestige of the move to monorepo. Nothing in here should be active or needed any longer.

TESTING INSTRUCTIONS

Just make sure chart creation still works, particularly DeckGL :)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #18706 (11c4aea) into master (225015f) will not change coverage.
The diff coverage is n/a.

❗ Current head 11c4aea differs from pull request most recent head de73226. Consider uploading reports for the commit de73226 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18706   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files        1605     1605           
  Lines       62863    62863           
  Branches     6341     6341           
=======================================
  Hits        41666    41666           
  Misses      19545    19545           
  Partials     1652     1652           
Flag Coverage Δ
javascript 51.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225015f...de73226. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 324a15d into master Feb 14, 2022
@rusackas rusackas deleted the removing-temporary-superset-ui branch February 14, 2022 15:10
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants