Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump echarts to 5.3.0 #18162

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Conversation

villebro
Copy link
Member

@villebro villebro commented Jan 25, 2022

SUMMARY

Bump ECharts to 5.3.0. See changelog here: https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/ . Changes:

  • Feature: Implement alignAxis on Mixed Timeseries chart to align y-axes when using dual axes.
  • Feature parity with previous version: add lineStyle to default emphasis on Timeseries charts to retain bolding of series when hoving the chart (added TODO to revisit this later).

AFTER

See how the major y-axis tick marks are now aligned:
image

BEFORE

Same data, ticks are unaligned:
image

Changelog: https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/

TODO: upgrade npm package when package is released.

TESTING INSTRUCTIONS

  1. Create new Mixed Timeseries chart using example FCC dataset
  2. Use COUNT(*) as metric on first query, COUNT(*) / 700.0 as metric on second query.
  3. Set axis of second query to "Secondary"

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #18162 (6167dad) into master (fa104fe) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18162      +/-   ##
==========================================
- Coverage   65.95%   65.92%   -0.03%     
==========================================
  Files        1584     1587       +3     
  Lines       62063    62119      +56     
  Branches     6273     6286      +13     
==========================================
+ Hits        40934    40953      +19     
- Misses      19508    19544      +36     
- Partials     1621     1622       +1     
Flag Coverage Δ
javascript 50.85% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 80.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.83% <ø> (ø)
...rc/explore/components/controls/TextAreaControl.jsx 80.00% <0.00%> (-4.22%) ⬇️
...et-frontend/src/components/TableSelector/index.tsx 62.65% <0.00%> (-0.32%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.46% <0.00%> (-0.22%) ⬇️
superset-frontend/src/preamble.ts 0.00% <0.00%> (ø)
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
superset-frontend/src/setup/setupClient.ts 0.00% <0.00%> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa104fe...6167dad. Read the comment docs.

@stephenLYZ
Copy link
Member

Looks good to me. There is a break change that removes the default bolding emphasis effect in the line chart. https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/#removing-the-default-bolding-emphasis-effect-in-the-line-chart. Should we need to adapt it? Although I think it's not important.

@villebro
Copy link
Member Author

villebro commented Jan 27, 2022

Looks good to me. There is a break change that removes the default bolding emphasis effect in the line chart. https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/#removing-the-default-bolding-emphasis-effect-in-the-line-chart. Should we need to adapt it? Although I think it's not important.

@stephenLYZ yes, good catch. I noticed it and actually thought it kind of looked cleaner, but I agree we should probably propose changing it in a separate PR and retain feature parity in this PR 👍

@villebro villebro changed the title [WIP] chore: bump echarts to 5.3.0 chore: bump echarts to 5.3.0 Jan 27, 2022
@zhaoyongjie zhaoyongjie self-assigned this Jan 27, 2022
@zhaoyongjie zhaoyongjie self-requested a review January 27, 2022 09:25
@villebro villebro merged commit dbe0a8b into apache:master Jan 27, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* chore: bump echarts to 5.3.0

* change to official 5.3.0 and reintroduce bold effect
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
* chore: bump echarts to 5.3.0

* change to official 5.3.0 and reintroduce bold effect
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* chore: bump echarts to 5.3.0

* change to official 5.3.0 and reintroduce bold effect
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants