Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard full screen layout #17985

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jan 10, 2022

SUMMARY

This pr possibly fixes an issue where user enter full screen and the page errors out. This could be possibly because of an outdated param passed into the getdashboardurl util.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-01-10.at.1.41.54.PM.mov

TESTING INSTRUCTIONS

Go to dashboard and go to three dots and click enter full screen mode. Should enter and exit without error.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson changed the title Fix: dashboard full screen layout fix: dashboard full screen layout Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #17985 (f547976) into master (05d9cde) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f547976 differs from pull request most recent head 30d878b. Consider uploading reports for the commit 30d878b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17985   +/-   ##
=======================================
  Coverage   67.10%   67.10%           
=======================================
  Files        1612     1612           
  Lines       64999    65000    +1     
  Branches     6872     6873    +1     
=======================================
+ Hits        43616    43619    +3     
+ Misses      19513    19512    -1     
+ Partials     1870     1869    -1     
Flag Coverage Δ
javascript 53.78% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/Header/HeaderActionsDropdown/index.jsx 71.42% <ø> (ø)
...lugins/plugin-chart-table/src/utils/formatValue.ts 70.58% <0.00%> (+14.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d9cde...30d878b. Read the comment docs.

@pkdotson
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://52.13.228.119:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit c139312 into apache:master Jan 10, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas deleted the fix-dashboard-reload branch January 10, 2022 23:08
@rosemarie-chiu
Copy link
Contributor

🏷 2022.1

rosemarie-chiu pushed a commit to preset-io/superset that referenced this pull request Jan 10, 2022
* fix: full screen mode for dashboard

* remove console

(cherry picked from commit c139312)
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* fix: full screen mode for dashboard

* remove console
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* fix: full screen mode for dashboard

* remove console
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.1 preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants