chore: fixing annoying warning about escaping in Emotion styling #17972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17972 +/- ##
=======================================
Coverage 67.08% 67.08%
=======================================
Files 1611 1611
Lines 64919 64919
Branches 6871 6871
=======================================
Hits 43548 43548
Misses 19504 19504
Partials 1867 1867
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
…che#17972) * chore: fixing annoying warning about escaping in Emotion styling * linting ✨
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
…che#17972) * chore: fixing annoying warning about escaping in Emotion styling * linting ✨
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There's been a little console warning that's been annoying me. So here's the one-character PR to make it go away! :D
Now it's gone!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
I made an annotation and tried to look for the entity (black pointing down triangle), but could not spot either the entity, nor any change from this PR. I'm not sure this styling has any effect at all. I think these annotations need a style/UX overhaul anyway ¯\_(ツ)_/¯ I'm pretty sure this PR is safe enough.
ADDITIONAL INFORMATION