refactor: import value name from root of superset-ui/core

[zhaoyongjie]

SUMMARY

Currently, there are multiple ways to import a value name from superset-ui/core, this confusing import expression makes the codebase difficult to maintain.

You can use following approach in superset-frontend/src with Webpack, the config at here

1. import { ensureIsArray } from '@superset-ui/core'

You can use following approach in superset-frontend/packages/superset-ui-core/test with Jest and Eslint, the config at here(Jest) and here(Eslint).

1. import { ensureIsArray } from '@superset-ui/core'
2. import { ensureIsArray } from '@superset-ui/core/src/utils/ensureIsArray'
3. import { ensureIsArray } from '../../some/relative/path'

This PR enforces the codebase using unified import expression: import { ensureIsArray } from '@superset-ui/core'. If you want to import an internal(private) module from '@superset-ui/core', you should use relative import and export the corresponding value name.

after the PR, eslint rules will prevent following import expression

1. ❌ import { ensureIsArray } from '@superset-ui/core/src/some/path
2. ❌ import { testValueName } from '@superset-ui/core/test/some/path
3. ❌ import { valueNameFromLib } from @superset-ui/core/lib/some/path

after the PR, eslint rules will approve following import expression

1. ✔️ import { ensureIsArray } from '@superset-ui/core'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17947 (50a694d) into master (79b6dc2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17947   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64905    64905           
  Branches     6868     6868           
=======================================
  Hits        43537    43537           
  Misses      19502    19502           
  Partials     1866     1866           

Flag	Coverage Δ
javascript	53.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b6dc2...50a694d. Read the comment docs.

[villebro]

Thanks for cleaning this up, this will ensure a much nicer development experience!

[michael-s-molina]

Love it!

[michael-s-molina]

Since the packages are self-contained, is there a way to set something in each package.json or globally to make packages/<package-name> as the root for each package and avoid the ../../.. imports?

[zhaoyongjie]

IMO, have to keep a simple and straightforward approach to link modules. We have to consider multiple runtime to alias these module

• Eslint
• Jest
• Webpack

This pattern only keep 1 principle "public variable name import from top level"

What do you think about it?