Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move edit dataset lock #17930

Merged

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

Moved the edit dataset lock to the top of the component in order to increase visibility.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

editDatasetLockBefore

AFTER:

editDatasetLockAfter

TESTING INSTRUCTIONS

  • Observe the described changes in the Edit Dataset model under the "Source" tab.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #17930 (8a5e4a9) into master (97a78d3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17930   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64903    64903           
  Branches     6866     6866           
=======================================
  Hits        43535    43535           
  Misses      19502    19502           
  Partials     1866     1866           
Flag Coverage Δ
javascript 53.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/Datasource/DatasourceEditor.jsx 68.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a78d3...8a5e4a9. Read the comment docs.

@eschutho
Copy link
Member

eschutho commented Jan 5, 2022

cc @yousoph

@lyndsiWilliams lyndsiWilliams merged commit df69920 into apache:master Jan 10, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/move-edit-dataset-lock branch January 10, 2022 22:55
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants