Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update query states to use spinner vs. progress bar #17804

Merged
merged 8 commits into from
Jan 5, 2022
Merged

feat: Update query states to use spinner vs. progress bar #17804

merged 8 commits into from
Jan 5, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Dec 17, 2021 •
edited
Loading

SUMMARY

Updated the progress bar to use the spinner in fetching state when progress is 100. Whenever the users lands in a fetching with a large amount of data it causes a bad user experience since it takes a while for the data to render. With the spinner we provide a better experience and provides UI consistency in our loading states.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-12-16 at 2 24 29 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title feat: Update query states to use spinner vs. progress barf feat: Update query states to use spinner vs. progress bar Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #17804 (d9f69f6) into master (cac704d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17804      +/-   ##
==========================================
+ Coverage   67.07%   67.11%   +0.03%     
==========================================
  Files        1609     1609              
  Lines       64899    65016     +117     
  Branches     6866     6910      +44     
==========================================
+ Hits        43533    43636     +103     
- Misses      19500    19509       +9     
- Partials     1866     1871       +5
Flag Coverage Δ
hive 53.29% <ø> (ø)
javascript 53.87% <100.00%> (+0.09%) ⬆️
mysql 82.19% <ø> (ø)
postgres 82.24% <ø> (ø)
presto 53.13% <ø> (ø)
python 82.68% <ø> (ø)
sqlite 81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 53.84% <100.00%> (+0.42%) ⬆️
superset-frontend/src/setup/setupColors.ts 75.00% <0.00%> (-6.82%) ⬇️
...ntend/packages/superset-ui-core/src/color/index.ts 100.00% <0.00%> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <0.00%> (ø)
...ashboard/components/gridComponents/ChartHolder.jsx 62.99% <0.00%> (+4.16%) ⬆️
superset-frontend/src/middleware/asyncEvent.ts 79.56% <0.00%> (+10.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac704d...d9f69f6. Read the comment docs.

@hughhhh
Copy link
Member Author

hughhhh commented Jan 4, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

@hughhhh Ephemeral environment spinning up at http://35.164.237.142:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

betodealmeida
betodealmeida approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@hughhhh hughhhh merged commit 9e69940 into master Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

Ephemeral environment shutdown and build artifacts deleted.

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@hughhhh @shcoderAlex
feat: Update query states to use spinner vs. progress bar (apache#17804)
0996d5f 
* lit

* remove reference for progress bar

* update to loading

* update switch out spinner for loading when progress hits 100

* update test
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@hughhhh @bwang221
feat: Update query states to use spinner vs. progress bar (apache#17804)
146a666 
* lit

* remove reference for progress bar

* update to loading

* update switch out spinner for loading when progress hits 100

* update test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the rm-pg-bar branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughhhh @betodealmeida @mistercrunch