Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra column in metrics #17784

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Similar to (and stacked upon) #17740, this handles the extra column in dataset metrics.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #17784 (928d467) into master (c49545a) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 928d467 differs from pull request most recent head 8baf887. Consider uploading reports for the commit 8baf887 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17784      +/-   ##
==========================================
- Coverage   67.03%   66.91%   -0.12%     
==========================================
  Files        1609     1609              
  Lines       64877    64882       +5     
  Branches     6863     6863              
==========================================
- Hits        43488    43416      -72     
- Misses      19525    19602      +77     
  Partials     1864     1864              
Flag Coverage Δ
hive ?
mysql 82.19% <100.00%> (+<0.01%) ⬆️
postgres 82.24% <100.00%> (+<0.01%) ⬆️
python 82.32% <100.00%> (-0.26%) ⬇️
sqlite 81.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/schemas.py 97.03% <100.00%> (+0.11%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-0.84%) ⬇️
superset/db_engine_specs/base.py 88.29% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-0.23%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49545a...8baf887. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 22, 2021
@betodealmeida betodealmeida merged commit 30c0459 into apache:master Dec 22, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:review Requires a code review size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants