Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): make SORT DESCENDING visible if SORT BY has value #17726

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Dec 13, 2021

SUMMARY

enhancement: Currently, if SORT BY is not set, SORT DESCENDING is not effective, for this reason, it will mislead the user, here we change it to show this control only if sort by is set.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

image

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #17726 (4152dd4) into master (4beaa81) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17726      +/-   ##
==========================================
- Coverage   67.79%   67.77%   -0.02%     
==========================================
  Files        1605     1605              
  Lines       64207    64224      +17     
  Branches     6790     6791       +1     
==========================================
+ Hits        43529    43530       +1     
- Misses      18822    18838      +16     
  Partials     1856     1856              
Flag Coverage Δ
javascript 54.80% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/legacy-plugin-chart-horizon/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...acy-plugin-chart-paired-t-test/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gin-chart-parallel-coordinates/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...legacy-plugin-chart-partition/src/controlPanel.tsx 25.00% <0.00%> (-8.34%) ⬇️
...egacy-plugin-chart-pivot-table/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx 50.00% <0.00%> (-50.00%) ⬇️
...ns/legacy-plugin-chart-treemap/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts 10.00% <0.00%> (-1.12%) ⬇️
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 95.83% <0.00%> (-4.17%) ⬇️
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <0.00%> (-10.00%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4beaa81...4152dd4. Read the comment docs.

@stephenLYZ stephenLYZ closed this Dec 14, 2021
@stephenLYZ stephenLYZ reopened this Dec 14, 2021
Copy link
Contributor

@riahk riahk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if SORT BY is set, does it sort descending by default?

@stephenLYZ
Copy link
Member Author

So if SORT BY is set, does it sort descending by default?

Right.

@zhaoyongjie zhaoyongjie merged commit d5768ab into apache:master Dec 21, 2021
@eschutho eschutho added v1.4.2 and removed v1.4.1 labels Jan 27, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@villebro villebro removed the v1.4.2 label Mar 21, 2022
@villebro
Copy link
Member

Removed 1.4.2 label as this cherry requires monorepo which isn't available on the 1.4 branch

@ElevenDog
Copy link

why exist default sort(sort by x-field) this maybe cause The Chart Result data difference to sqlab query result

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants