Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): deck.gl Multiple chart broken #17703

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

stephenLYZ
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2021-12-09.6.36.40.mov

after

2021-12-09.6.35.28.mov

TESTING INSTRUCTIONS

see #16572

ADDITIONAL INFORMATION

  • Has associated issue: deck.gl Multiple Layers chart broke after 1.2.0 #16572
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #17703 (a1eb5a5) into master (3a42071) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head a1eb5a5 differs from pull request most recent head 19220fa. Consider uploading reports for the commit 19220fa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17703      +/-   ##
==========================================
- Coverage   67.97%   67.97%   -0.01%     
==========================================
  Files        1653     1653              
  Lines       66282    66283       +1     
  Branches     7107     7108       +1     
==========================================
  Hits        45055    45055              
  Misses      19338    19338              
- Partials     1889     1890       +1     
Flag Coverage Δ
javascript 56.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/DataTablesPane/index.tsx 76.92% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a42071...19220fa. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@villebro villebro merged commit bdc4e7a into apache:master Dec 9, 2021
tesshy added a commit to MaaSTechJapan/superset that referenced this pull request Feb 22, 2022
@leafant
Copy link

leafant commented Mar 16, 2022

This issue is still in release version 1.4.1>

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.4.1 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants