chore: updated screenshots in README.md and added recent events #17650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17650 +/- ##
=======================================
Coverage 67.18% 67.18%
=======================================
Files 1609 1609
Lines 64796 64796
Branches 6855 6855
=======================================
Hits 43530 43530
Misses 19410 19410
Partials 1856 1856
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
rusackas
reviewed
Dec 7, 2021
rusackas
reviewed
Dec 7, 2021
README.md
Outdated
| - A **lightweight semantic layer** for quickly defining custom dimensions and metrics | ||
| - Out of the box support for **nearly any SQL** database or data engine | ||
| - A wide array of **beautiful visualizations** to showcase your data | ||
| metadata browser |
There was a problem hiding this comment.
This line looks wrong... is this a separate item?
rusackas
reviewed
Dec 7, 2021
README.md
Outdated
|
|
||
| <kbd><img title="View Dashboards" src="superset-frontend/src/assets/images/screenshots/slack_dash.jpg"/></kbd><br/> | ||
|
|
||
| **Slice & dice your data** | ||
| **No Code Chart Builder** |
There was a problem hiding this comment.
Suggested change
| **No Code Chart Builder** | |
| **No-Code Chart Builder** |
This seems like it should be hyphenated. Maybe. ¯\_(ツ)_/¯
rusackas
reviewed
Dec 7, 2021
rusackas
reviewed
Dec 7, 2021
riahk
reviewed
Dec 7, 2021
9 tasks
Co-authored-by: Evan Rusackas <evan@preset.io>
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
…he#17650) * chore: updated screenshots in readme.md and added recent events * chore: updated pinot superset connection instructions * fixed outdated slack link * addressed all outstanding feedback! * updated package lock * reverted package.json to master * Update README.md Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Evan Rusackas <evan@preset.io>
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
…he#17650) * chore: updated screenshots in readme.md and added recent events * chore: updated pinot superset connection instructions * fixed outdated slack link * addressed all outstanding feedback! * updated package lock * reverted package.json to master * Update README.md Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Evan Rusackas <evan@preset.io>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated screenshots in README.MD:
Added some database logos: