Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(monorepo): frontend code cleanup after monorepo #17639

Merged
merged 5 commits into from
Dec 4, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Dec 3, 2021

SUMMARY

  1. remove unused files and settings
  2. arrange tsconfig

TESTING INSTRUCTIONS

CI passed

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie changed the title Chore: frontend code cleanup after monorepo refactor(monorepo): frontend code cleanup after monorepo Dec 3, 2021
"noImplicitAny": true,
"noImplicitReturns": true,
"noImplicitThis": true,
"noUnusedLocals": true,
"outDir": "./dist",
"pretty": true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pretty" default value is true, remove it.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #17639 (a713e53) into master (73e7928) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17639   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files        1595     1595           
  Lines       65184    65184           
  Branches     6945     6945           
=======================================
  Hits        44814    44814           
  Misses      18488    18488           
  Partials     1882     1882           
Flag Coverage Δ
javascript 57.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e7928...a713e53. Read the comment docs.

@@ -33,20 +24,42 @@
],
"@superset-ui/plugin-chart-*": ["./plugins/plugin-chart-*/src"],
"@superset-ui/preset-chart-*": ["./plugins/preset-chart-*/src"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe L15-26 can be updated to

      "@superset-ui/*": [
        "./node_modules/@superset-ui/*/src",
        "./node_modules/@superset-ui/*",
      ],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, I got this error when I make this change. I will make a separate PR to improve it.

image

@zhaoyongjie zhaoyongjie merged commit 4306289 into apache:master Dec 4, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants