Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(exploring-data): Add upload excel notes #17502

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Conversation

aniaan
Copy link
Contributor

@aniaan aniaan commented Nov 22, 2021

SUMMARY

Add upload excel notes

ADDITIONAL INFORMATION

cc: @zhaoyongjie

Comment on lines +29 to +31
**Note:** To enable `Upload Excel`, you need to make sure that the `xlrd` dependency is installed,
which you can execute `pip install apache-superset[excel]` to install.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, would you mind updating line 26 to state that we also support The Parquet columnar format for data uploads?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@villebro Of course, it has been updated.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aniaan ! Merging when CI is green

@villebro villebro merged commit c7a7865 into apache:master Nov 23, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* docs(exploring-data): Add upload excel notes

* docs(exploring-data): Add upload Columnar file notes

* docs(exploring-data): fix typo
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants