Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run npm install to fix a bad package version #17314

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Nov 1, 2021

SUMMARY

npm ci was breaking in some cases because there was a difference in the version of the required packages of react-ace in the package-lock.json file.

TESTING INSTRUCTIONS

Builds should work properly, and ace editors should still work

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #17314 (5f07994) into master (a898883) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17314   +/-   ##
=======================================
  Coverage   77.09%   77.09%           
=======================================
  Files        1037     1037           
  Lines       55647    55647           
  Branches     7608     7608           
=======================================
  Hits        42899    42899           
  Misses      12498    12498           
  Partials      250      250           
Flag Coverage Δ
javascript 71.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a898883...5f07994. Read the comment docs.

@eschutho eschutho merged commit bea8502 into apache:master Nov 1, 2021
@eschutho eschutho deleted the elizabeth/fix-npm-install branch November 1, 2021 20:57
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants