Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix table height in Change dataset modal when pagination is off #16275

Merged
merged 1 commit into from
Aug 17, 2021
Merged

fix: Fix table height in Change dataset modal when pagination is off #16275

merged 1 commit into from
Aug 17, 2021

Conversation

geido
Copy link
Member

@geido geido commented Aug 16, 2021

SUMMARY

This PR fixes an issue with the height of the table inside the Change dataset modal when the pagination is off, which was causing a blank space to appear.

BEFORE

DEV.Cross.Chan.mp4

AFTER

DEV.Pivot.Tabl.1.mp4

TESTING INSTRUCTIONS

  1. Open a chart in Explore
  2. Click on Change dataset
  3. Observe the table height and make sure there is no blank space at the bottom

ADDITIONAL INFORMATION

  • Has associated issue: Fixes explore: Change dataset modal shows unnecessary blank space #16249
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the improvement

@geido
Copy link
Member Author

geido commented Aug 16, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.220.104.198:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we dismiss the warning message, we have a blank space at the bottom.

Screen.Recording.2021-08-16.at.4.26.39.PM.mov

@geido
Copy link
Member Author

geido commented Aug 16, 2021

Hello @michael-s-molina that is a different issue which isn't related to my changes and that affect master as well. I will file an issue for that problem and submit a separate fix when these changes are merged in.

@geido geido merged commit 9876c36 into apache:master Aug 17, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@geido geido deleted the fix/issue_16249_modal_blank_space branch August 17, 2021 07:59
@michael-s-molina
Copy link
Member

michael-s-molina commented Aug 17, 2021

Hello @michael-s-molina that is a different issue which isn't related to my changes and that affect master as well. I will file an issue for that problem and submit a separate fix when these changes are merged in.

@geido I added a comment about improving the criteria of splitting the PRs here. For me, this is the perfect example where we will add unnecessary overhead to a simple fix that should only be another commit.

@geido
Copy link
Member Author

geido commented Aug 17, 2021

@michael-s-molina I agree this would have worked perfectly in one PR. However, my intention here was to fix the most perceivable issue first and then work on a separate PR to revisit this problem entirely. In fact, this issue has been coming back in a way or another few times and I believe it requires a more comprehensive solution and probably some refactoring work as well.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explore: Change dataset modal shows unnecessary blank space
4 participants