-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(explore): Create new entrypoints for Echarts Timeseries #15942
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15942 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 995 995
Lines 52866 52866
Branches 6713 6713
=======================================
Hits 40605 40605
Misses 12035 12035
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b2db549
to
255fefd
Compare
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true |
@villebro Ephemeral environment spinning up at http://34.214.9.184:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested to the best of my ability, and all looks solid
Ephemeral environment shutdown and build artifacts deleted. |
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true |
@villebro Container image not yet published for this PR. Please try again when build is complete. |
@villebro Ephemeral environment creation failed. Please check the Actions logs for details. |
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true |
@villebro Ephemeral environment spinning up at http://52.33.88.219:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
Ephemeral environment shutdown and build artifacts deleted. |
🏷 2021.31 |
* feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit a59d458)
* feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit a59d458)
…#15942) * feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
…#15942) * feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
SUMMARY
This PR adds the new charts/entry points implemented in apache-superset/superset-ui#1249. For more details, see description.
apache-superset/superset-ui#1249 must be merged before this PR! After that, the superset-ui versions need to be bumped
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See apache-superset/superset-ui#1249
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
@junlincc @villebro