fix: Teradata connection fixes

[mccushjack]

SUMMARY

fixes to Teradata driver and limit methods in teradata.py

TEST PLAN

This solution works and is tested with Teradata Vantage, but we are happy to make other modifications if the team supports.

ADDITIONAL INFORMATION

The request all realtes to the follwoing bug

New or Changed Public Interfaces
The present proposal requires no new or changed public interfaces.

New dependencies

Only for Teradata connections, the present proposal requires the installation of

the teradatasqlalchemy connector, and
the teradatasql driver
packages to connect to a Teradata Vantage system Advanced SQL Engine Database.
These packages are actively maintained and their licenses are Teradata proprietary. The teradatasql license can be found at:
https://github.com/Teradata/python-driver/blob/master/LICENSE
whereas the teradatasqlalchemy code is not publicly posted at this point.

Migration Plan and Compatibility
No migration is necessary. The proposed code changes are an extension and non-destructive to the existing code, thus not affecting existing compatibility.

[villebro]

@mccushjack I'm going through old unreviewed PRs, and sadly this valuable PR had gone unreviewed. Can you rebase this PR to resolve the conflict? I'll finish reviewing this once that gets done.

[villebro]

@mccushjack oh no, this is conflicted again 🙁 Would you mind rebasing one more time and pinging me when you're done so I can get this merged?

[junlincc]

@mccushjack 🙏

[cwiebe18]

@junlincc we are sending cheesecake to @mccushjack to ask him, pretty pls :-)

[cwiebe18]

@mccushjack thank you so much!

@junlincc @villebro anything you could do to nudge this along would be so appreciated!

[mccushjack]

@junlincc @villebro and @cwiebe18 -- The rebase is complete. The only major change outside of teradata.py fixes was an update to the main setup.py for loading Teradata's native python driver which removes the dependency on odbc driver. This should make interoperability easier and more seamless. LMK if you have any questions or comments.

[michael-s-molina]

@mccushjack I think something went wrong with the rebase. It's showing 1,099 file changes.

[villebro]

@mccushjack did you notice the failed unit test? I believe this is good to go once it's fixed:

[nytai]

@mccushjack seems like linting is failing for this PR. Sorry it has taken so long to get this change merged/reviewed. If you wouldn't mind fixing the lint errors and getting CI passing again, I'll make sure this gets merged. If you're part of the superset slack, feel free to ping me to get things expedited.

[mccushjack]

@nytai I got some help to fix our unit test. I think everything is working now let @mccushjack and @dmcnulla know if there are any updates needed.

[dmcnulla]

I do not know what this Python Misc/pre-commit check does, and I cannot tell from the error what is wrong. Can I buy a clue from somebody?

[nytai]

It runs a few linting type checks. @dmcnulla to get this check passing, the following steps should work.

• make an edits to superset/tests/unit_tests/db_engine_specs/test_teradata.py and superset/superset/db_engine_specs/teradata.py (can be simple blank space change)
• stage those files git add .
• run pre-commit (should be installed via requirements/integration.txt)

[nytai]

Closing, as this work was absorbed by #18240