refactor: New schedule query button #13797
Conversation
AAfghahi
force-pushed
the
newScheduleQueryButton
branch
2 times, most recently
from
06c4144
to
ce272ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #13797 +/- ##
==========================================
+ Coverage 76.79% 77.49% +0.69%
==========================================
Files 934 934
Lines 47201 47206 +5
Branches 5876 5882 +6
==========================================
+ Hits 36248 36581 +333
+ Misses 10794 10483 -311
+ Partials 159 142 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AAfghahi
force-pushed
the
newScheduleQueryButton
branch
from
ce272ce
to
f810de7
Compare
| import Form, { FormProps, FormValidation } from 'react-jsonschema-form'; | ||
| import { Col, FormControl, FormGroup, Row } from 'react-bootstrap'; | ||
| import { t, styled } from '@superset-ui/core'; | ||
| import * as chrono from 'chrono-node'; |
There was a problem hiding this comment.
@AAfghahi This library is missing type definition and local webpack is throwing TS errors. I'm surprised CI didn't catch this.
There was a problem hiding this comment.
Hey! I was running into the same issue, did you do npm install? That solved it for me. The earlier versions don't have type definitions and the later ones do. One of the changes was to package.json.
There was a problem hiding this comment.
I'm pretty sure I did but I was still seeing the error. Nevertheless, I bumped it again to the latest in package.json and it works.
There was a problem hiding this comment.
Thank you for bumping the version.
|
|
||
| const getJSONSchema = () => { | ||
| const jsonSchema = window.featureFlags.SCHEDULED_QUERIES?.JSONSCHEMA; | ||
| // parse date-time into usable value (eg, 'today' => `new Date()`) |
There was a problem hiding this comment.
For this feature, though, @zhaoyongjie implemented an awesome date parser (in Python) for time filters, @AAfghahi @hughhhh do you think it would make sense to consolidate these to use the same API?
mistercrunch
added
🏷️ bot
SUMMARY
this is a rebase of the first one.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION