feat(native-filters): Filter set tabs #13507

simcha90 · 2021-03-07T08:47:44Z

SUMMARY

Add filter set tabs according: https://www.figma.com/proto/Z75uj6W6n0A6nfK3Mvawqi/Dashboard-Filters---P1?node-id=960%3A446&scaling=min-zoom

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-03-07.at.10.45.00.mov

TEST PLAN

ADDITIONAL INFORMATION

…_to_data_mask

…incubator-superset into filter_bar_actions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx

…_to_data_mask � Conflicts: � superset-frontend/package-lock.json � superset-frontend/package.json

…incubator-superset into filter_bar_actions

…ctions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx

� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx

codecov · 2021-03-07T10:21:02Z

Codecov Report

Merging #13507 (93e5d97) into master (7b370e6) will decrease coverage by 4.06%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master   #13507      +/-   ##
==========================================
- Coverage   77.00%   72.93%   -4.07%     
==========================================
  Files         912      612     -300     
  Lines       46034    21506   -24528     
  Branches     5587     5588       +1     
==========================================
- Hits        35448    15686   -19762     
+ Misses      10455     5688    -4767     
- Partials      131      132       +1

Flag	Coverage Δ
cypress	`57.50% <25.53%> (-0.08%)`	⬇️
javascript	`62.91% <40.00%> (-0.05%)`	⬇️
mysql	`?`
postgres	`?`
python	`?`
sqlite	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...hboard/components/nativeFilters/FilterBar/state.ts	`94.11% <ø> (-0.89%)`	⬇️
.../components/nativeFilters/FilterBar/FilterSets.tsx	`28.26% <28.26%> (ø)`
...d/components/nativeFilters/FilterBar/FilterBar.tsx	`93.85% <85.71%> (+11.46%)`	⬆️
superset/datasets/commands/create.py
superset/datasets/commands/update.py
superset/charts/commands/update.py
superset/models/user_attributes.py
superset/utils/urls.py
superset/reports/commands/bulk_delete.py
superset/constants.py
... and 295 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b370e6...93e5d97. Read the comment docs.

villebro

Some comments about naming, other than that looks great!

villebro · 2021-03-07T12:45:22Z

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets.tsx

+    string | null
+  >(null);
+
+  const takeFiltersSet = (value: string) => {


While we're moving these, it would be nice to rename these to comply with the "Filter set" name instead of "Filters set". In this case, this could be takeFilterSet. Also, "id" might be a more descriptive variable name than "value" here.

this function will be moved and renamed in the next PR

villebro · 2021-03-07T12:47:41Z

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets.tsx

+    <Sets>
+      <FilterSet>
+        <StyledTitle>
+          <div>{t('Choose filters set')}</div>


I think this should be "Choose filter set"

and same here, because this functionality going to be changed

simcha90 added 29 commits March 3, 2021 14:24

refactor(native-filters): move data mask to root reducer

2731518

Merge branch 'master' of github.com:apache/superset into filtersState…

de6a332

…_to_data_mask

refactor: update rest stuff for dataMask

6652d19

refactor: add ownCrrentState to explore

266a0a3

fix: fix immer reducer

5344dd4

Merge branch 'master' of github.com:apache/superset into filtersState…

2b4bd8f

…_to_data_mask

fix: merge with master

dabfd24

refactor: support explore dataMask

802823c

refactor: support explore dataMask

8aed240

docs: add comment

a0fa114

refactor: remove json stringify

eaec7ef

fix: fix failed cases

cba3467

feat: filter bat buttons start

04d6398

fix: fix CR notes

af9e35a

fix: fix cascade filters

64fb87d

fix: fix CR notes

57c954f

Merge branch 'filtersState_to_data_mask' of github.com:simchaNielsen/…

bd9b767

…incubator-superset into filter_bar_actions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx

refactor: add clear all

bff44d1

fix: fix CR notes

09b594a

Merge branch 'master' of github.com:apache/superset into filtersState…

c522391

…_to_data_mask � Conflicts: � superset-frontend/package-lock.json � superset-frontend/package.json

Merge branch 'filtersState_to_data_mask' of github.com:simchaNielsen/…

1bf1552

…incubator-superset into filter_bar_actions

fix: fix CR notes

0527067

Merge branch 'filtersState_to_data_mask' of github.com:simchaNielsen/…

9abe26e

…incubator-superset into filter_bar_actions

fix: fix CR notes

2d12c37

Merge branch 'filtersState_to_data_mask' of github.com:simchaNielsen/…

84d8cbd

…incubator-superset into filter_bar_actions

feat: buttons in filter bar

a9202b1

Merge branch 'master' of github.com:apache/superset into filter_bar_a…

9ae46b9

…ctions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx

lint: update imports

cdcae95

feat: add tabs for filter sets

6c91054

pull-request-size bot added the size/L label Mar 7, 2021

simcha90 added 2 commits March 7, 2021 11:49

Merge branch 'master' of github.com:apache/superset into filter-set_tabs

844adaa

� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx

Merge branch 'master' of github.com:apache/superset into filter-set_tabs

93e5d97

simcha90 changed the title ~~WIP: feat(native-filters): Filter set tabs~~ feat(native-filters): Filter set tabs Mar 7, 2021

villebro reviewed Mar 7, 2021

View reviewed changes

villebro approved these changes Mar 7, 2021

View reviewed changes

villebro merged commit f504b7f into apache:master Mar 7, 2021

junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Mar 12, 2021

allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021

feat(native-filters): Filter set tabs (apache#13507)

e6a8b8c

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(native-filters): Filter set tabs #13507

feat(native-filters): Filter set tabs #13507

simcha90 commented Mar 7, 2021

codecov bot commented Mar 7, 2021

villebro left a comment

villebro Mar 7, 2021

simcha90 Mar 7, 2021

villebro Mar 7, 2021

simcha90 Mar 7, 2021

feat(native-filters): Filter set tabs #13507

feat(native-filters): Filter set tabs #13507

Conversation

simcha90 commented Mar 7, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

codecov bot commented Mar 7, 2021

Codecov Report

villebro left a comment

Choose a reason for hiding this comment

villebro Mar 7, 2021

Choose a reason for hiding this comment

simcha90 Mar 7, 2021

Choose a reason for hiding this comment

villebro Mar 7, 2021

Choose a reason for hiding this comment

simcha90 Mar 7, 2021

Choose a reason for hiding this comment