feat(native-filters): Update filter bar buttons #13506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…incubator-superset into filter_bar_actions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
…_to_data_mask � Conflicts: � superset-frontend/package-lock.json � superset-frontend/package.json
…incubator-superset into filter_bar_actions
…incubator-superset into filter_bar_actions
…incubator-superset into filter_bar_actions
simcha90
changed the title
…ctions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
simcha90
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13506 +/- ##
==========================================
+ Coverage 71.73% 73.38% +1.65%
==========================================
Files 806 611 -195
Lines 40749 21345 -19404
Branches 4165 5539 +1374
==========================================
- Hits 29230 15665 -13565
+ Misses 11519 5550 -5969
- Partials 0 130 +130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
added
the
dashboard:native-filters
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* refactor(native-filters): move data mask to root reducer * refactor: update rest stuff for dataMask * refactor: add ownCrrentState to explore * fix: fix immer reducer * fix: merge with master * refactor: support explore dataMask * refactor: support explore dataMask * docs: add comment * refactor: remove json stringify * fix: fix failed cases * feat: filter bat buttons start * fix: fix CR notes * fix: fix cascade filters * fix: fix CR notes * refactor: add clear all * fix: fix CR notes * fix: fix CR notes * fix: fix CR notes * feat: buttons in filter bar * lint: update imports * test: fix tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR update filter bar action buttons functionality according this mock for filter sets:
https://www.figma.com/proto/Z75uj6W6n0A6nfK3Mvawqi/Dashboard-Filters---P1?node-id=960%3A515&scaling=min-zoom
It includes actions functionality for
Reset allandApplybuttonsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-03-07.at.9.20.56.mov
TEST PLAN
ADDITIONAL INFORMATION