fix(native-filters): set currentValue null when empty #13000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junlincc
added
the
dashboard:native-filters
Codecov Report
@@ Coverage Diff @@
## master #13000 +/- ##
===========================================
+ Coverage 53.17% 72.89% +19.72%
===========================================
Files 449 545 +96
Lines 14826 20162 +5336
Branches 3959 5268 +1309
===========================================
+ Hits 7884 14698 +6814
+ Misses 6942 5339 -1603
- Partials 0 125 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
changed the title
simcha90
reviewed
Feb 9, 2021
| @@ -76,7 +76,10 @@ export default function AntdPluginFilterSelect( | |||
| ), | |||
| // @ts-ignore (add to superset-ui/core) | |||
| currentState: { | |||
| value: resultValue, | |||
| value: | |||
| Array.isArray(resultValue) && resultValue.length === 0 | |||
There was a problem hiding this comment.
I think resultValue always is array according line 60
There was a problem hiding this comment.
Oh nice catch! I was getting value and resultValue mixed up here.
simcha90
approved these changes
Feb 9, 2021
villebro
force-pushed
the
villebro/empy-select-filter
branch
from
3fa9fd3
to
8f483c7
Compare
amitmiran137
approved these changes
Feb 13, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
* master: (30 commits) refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021) fix(native-filters): set currentValue null when empty (apache#13000) Custom superset_config.py + secret envs (apache#13096) Update http error code from 400 to 403 (apache#13061) feat(native-filters): add storybook entry for select filter (apache#13005) feat(native-filters): Time native filter (apache#12992) Force pod restart on config changes (apache#13056) feat(cross-filters): add cross filters (apache#12662) fix(explore): Enable selecting an option not included in suggestions (apache#13029) Improves RTL configuration (apache#13079) Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083) chore: lock down npm to v6 (apache#13069) fix: API tests, make them possible to run independently again (apache#13076) fix: add config to disable dataset ownership on the old api (apache#13051) add required * indicator to message content/notif method (apache#12931) fix: Retroactively add granularity param to charts (apache#12960) fix(ci): multiline regex in change detection (apache#13075) feat(style): hide dashboard header by url parameter (apache#12918) fix(explore): pie chart label bugs (apache#13052) fix: Disabled state button transition time (apache#13008) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently cascading filters evaluate truthiness of the parent filter when determining if the child filter should be rendered in place of the parent. Since the native Select filter returns an empty array for an empty selection, the parent filter is determined to be set, even though it isn't.
Here we change the cascading logic so that only
undefinedandnullare assumed to be unset. This is done because there may be other filters that have falsy values which in fact mean that the filter is set, for instance a lower range being set to0.SCREENSHOTS
In the example, I've constructed a cascading filter with "region" as the parent and "country" as the child. As can be seen, the "country" filter show up on the filter tab, despite the selection being empty on the "region" filter:
After the change, an empty selection is set as
null, making the parent filter display in the filter tab:TEST PLAN
ADDITIONAL INFORMATION