Fixed error of inserializable json for druid test #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
reviewed
Sep 29, 2016
| nres = [ | ||
| list(v['event'].items()) + [('timestamp', v['timestamp'])] | ||
| for v in GB_RESULT_SET] | ||
| list(v['event'].items()) + [('timestamp', v['timestamp'])] |
There was a problem hiding this comment.
@vera-liu - could you please fix indentation here ?
|
LGTM, feel free to merge once the travis turns green. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Previously druid tests were failing on alanna-explore-v2-main, this was because we load the json of viz_obj and pass it to refactored explore view: https://github.com/airbnb/caravel/pull/1205/files#diff-e9b1e371eebef6df66bd8cde507e5931R1217
In Druid test, the return value of export_pandas is defined after endpoint test, causing the test to fail when json.loads(viz_obj.get_json()) is called
Flow: get_json() calls -> get_data() calls -> get_df() calls -> query() calls ->export_pandas() -> returns a mock object instead of df
Solution (credits to Bogdan):
moving export_pandas mock definition before endpoint test
needs-review @ascott @bkyryliuk @mistercrunch