Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dataset editor update user list endpoint #11221

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

lilykuang
Copy link
Member

SUMMARY

  • update to new api/v1/dataset/related/owners

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #11221 into master will decrease coverage by 7.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11221      +/-   ##
==========================================
- Coverage   65.53%   58.52%   -7.02%     
==========================================
  Files         828      794      -34     
  Lines       39148    37882    -1266     
  Branches     3589     3389     -200     
==========================================
- Hits        25655    22169    -3486     
- Misses      13381    15526    +2145     
- Partials      112      187      +75     
Flag Coverage Δ
#cypress 55.87% <0.00%> (+0.81%) ⬆️
#javascript ?
#python 59.95% <ø> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/datasource/DatasourceEditor.jsx 45.90% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/databases/commands/create.py 31.91% <0.00%> (-59.58%) ⬇️
superset/db_engine_specs/hive.py 53.90% <0.00%> (-30.08%) ⬇️
superset/views/database/mixins.py 59.64% <0.00%> (-22.81%) ⬇️
superset/db_engine_specs/presto.py 69.76% <0.00%> (-12.32%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/databases/api.py 81.38% <0.00%> (-7.98%) ⬇️
superset/databases/dao.py 94.11% <0.00%> (-5.89%) ⬇️
... and 856 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d5e8a...c628757. Read the comment docs.

@dpgaspar dpgaspar merged commit 8e58730 into apache:master Oct 12, 2020
@dpgaspar dpgaspar deleted the dataset-editor-user-list-fix branch October 12, 2020 16:11
dpgaspar pushed a commit to preset-io/superset that referenced this pull request Oct 12, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 0.38.0 🍒 0.38.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🍒 0.38.0 🍒 0.38.1 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants