Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SpatialControl popover won't open #11127

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

mistercrunch
Copy link
Member

Recently a change related to emotion styling not properly working through
react-bootstrap's popover broke the SpatialControl.

This PR makes SpatialControl use antd's equivalent, and addresses the
issue as a result: emotion's styling context is preserved through
this superior popover.

Screen Shot 2020-09-30 at 10 30 54 PM

Recently a change related to emotion styling not properly working through
react-bootstrap's popover broke the SpatialControl.

This PR makes SpatialControl use antd's equivalent, and addresses the
issue as a result: emotion's styling context is preserved through
this superior popover.
@codecov-commenter
Copy link

Codecov Report

Merging #11127 into master will decrease coverage by 5.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11127      +/-   ##
==========================================
- Coverage   65.73%   60.10%   -5.63%     
==========================================
  Files         819      385     -434     
  Lines       38865    24323   -14542     
  Branches     3669        0    -3669     
==========================================
- Hits        25546    14619   -10927     
+ Misses      13209     9704    -3505     
+ Partials      110        0     -110     
Flag Coverage Δ
#cypress ?
#javascript ?
#python 60.10% <ø> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/databases/commands/create.py 31.91% <0.00%> (-59.58%) ⬇️
superset/db_engine_specs/hive.py 53.90% <0.00%> (-30.08%) ⬇️
superset/views/database/mixins.py 59.64% <0.00%> (-22.81%) ⬇️
superset/db_engine_specs/presto.py 69.76% <0.00%> (-12.32%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/databases/api.py 81.38% <0.00%> (-7.98%) ⬇️
superset/databases/dao.py 94.11% <0.00%> (-5.89%) ⬇️
superset/views/database/validators.py 78.94% <0.00%> (-5.27%) ⬇️
... and 450 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a4265...1ddd7ee. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want to give @kgabryje the chance to take a look at this and make any comments/suggestions before merging, since I know he's planning to do exactly this, across the board.


// Eventually Popover can be wrapped and customized in this file
// for now we're just redirecting
export default Popover;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on how we feel about the appearance of the popover, we may not need to do this, but I like this scaffolding to set us up for a little Emotion styling here. If the day comes that we do tweak the styles, let's just be sure to add it to Storybook!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I didn't know if we wanted to do this redirect here. Main goal was to fix SpatialControl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good pattern to do this, actually.

@mistercrunch mistercrunch merged commit c4d96f6 into apache:master Oct 1, 2020
@rusackas rusackas deleted the fix_spatialcontrol branch October 1, 2020 17:19
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Recently a change related to emotion styling not properly working through
react-bootstrap's popover broke the SpatialControl.

This PR makes SpatialControl use antd's equivalent, and addresses the
issue as a result: emotion's styling context is preserved through
this superior popover.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants