fix: Adding timeout to flaky cypress test, to wait for animation to complete

[rusackas]

SUMMARY

The remove, and add chart flow test seems to flake out fairly often, and I've seen it do so with errors saying that pointer-events were disabled by a parent's CSS, and that the element was still animating. I'm assuming that all of this is due to the animation and such that takes place when switching tabs. Here's hoping 1s of waiting will properly cover that issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Keep an eye on CI!

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[ktmud]

The way Cypress get works is to constantly retry querying the DOM until the elements that match the selector are found or timeout. https://docs.cypress.io/guides/core-concepts/retry-ability.html

So waiting arbitrary duration wouldn't really help with test flakiness. In fact, there is an ESLint rule to discourage that: https://docs.cypress.io/guides/references/best-practices.html

[rusackas]

The way Cypress get works is to constantly retry querying the DOM until the elements that match the selector are found or timeout. https://docs.cypress.io/guides/core-concepts/retry-ability.html

So waiting arbitrary duration wouldn't really help with test flakiness. In fact, there is an ESLint rule to discourage that: https://docs.cypress.io/guides/references/best-practices.html

The problem seems to be though that it IS finding an element that matches the selector, but that element is not yet in a state where it's completely visible (animating) or clickable (with pointer-events:none applied to it). It seems like it's just not waiting for that transition to finish before starting the drag step of the test.

[rusackas]

The help link for this error is here; it sounds like we're one of the "edge cases" they discuss, where the test is trying to interact with the element before it's finished animating.

[ktmud]

Wow, everyday I learn something new about Cypress. Thanks for the explanation! This sounds like a good theory. Let's hope it really does fix it!