fix(api): unable to delete virtual dataset, wrong permission name #11019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
changed the title
dpgaspar
commented
Sep 24, 2020
| if not view_menu: | ||
| logger.error( | ||
| "Could not find the data access permission for the dataset" | ||
| ) |
There was a problem hiding this comment.
If a dataset permission does not exist, log the error and delete anyway
dpgaspar
changed the title
dpgaspar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #11019 +/- ##
==========================================
- Coverage 65.76% 61.35% -4.41%
==========================================
Files 816 817 +1
Lines 38381 38523 +142
Branches 3606 3621 +15
==========================================
- Hits 25240 23637 -1603
- Misses 13033 14700 +1667
- Partials 108 186 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
craig-rueda
reviewed
Sep 24, 2020
| and replaces them with the current (correct) permission name | ||
| """ | ||
| from flask_appbuilder.security.sqla.models import ( | ||
| ViewMenu, |
There was a problem hiding this comment.
Should we be referencing concrete model classes in migrations? This migration will likely fail to run in the future should any of their structure change. Ideally, partial impl's, or copies should be defined directly in the migration in order to avoid such a situation. The other option is to roll all of these migrations up into a subset of what we currently have.
There was a problem hiding this comment.
Good point, I'll probably go for the model copy
villebro
reviewed
Sep 29, 2020
superset/migrations/versions/3fbbc6e8d654_fix_data_access_permissions_for_virtual_.py
Outdated
Show resolved
Hide resolved
…issions_for_virtual_.py Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
villebro
approved these changes
Sep 29, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…ache#11019) * fix(api): unable to delete virtual dataset because of wrong permission name * Still delete the dataset even when no permission was found * migration script to fix possible existing faulty permissions on the db * black * fix db migration and one more test * add more comments to the migration script * freeze a partial schema of the model on the migration step * fix mig script * Update superset/migrations/versions/3fbbc6e8d654_fix_data_access_permissions_for_virtual_.py Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When creating a virtual dataset using SQLLab -> Explorer the call to
superset/sqllab_vizcreates a newSqlaTablewithdatabase_idset, notdatabase. This causes a problem on the SQLAlchemy listener that creates/updates permissions on insert/update. Because thedatabaserelation is not set yet at this time theget_perm()method on the SqlaTable return a permission with[None].[<VIRTUAL DS NAME>](id:22)instead of[examples].[<VIRTUAL_DS_NAME>](id:22)When deleting the new dataset delete command will check if the permission for the dataset exists (to delete it also) and this sanity check failed, refusing to delete the dataset. We will delete the dataset and just log an error on this PR.
Also added a migration revision that does its best on fixing any existing faulty data access permissions.
ADDITIONAL INFORMATION