Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pylint disabled rules in dashboard/api.py #10976

Merged
merged 4 commits into from
Sep 21, 2020
Merged

fix: pylint disabled rules in dashboard/api.py #10976

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6babaa
Refactored `put` method in dashboards/api.py:
kkucharc Sep 21, 2020
f67524c
`arguments-differ` disabled rule is not anymore valid - put argiments…
kkucharc Sep 21, 2020
c31c950
`delete()` method in dashboards/api has now same list of argiments:
kkucharc Sep 21, 2020
b14e85e
`bulk_delete()` method in dashboards/api has now same list of argiments:
kkucharc Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions superset/dashboards/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,7 @@ def post(self) -> Response:
@protect()
@safe
@statsd_metrics
def put( # pylint: disable=too-many-return-statements, arguments-differ
self, pk: int
) -> Response:
def put(self, pk: int) -> Response:
"""Changes a Dashboard
---
put:
Expand Down Expand Up @@ -286,24 +284,25 @@ def put( # pylint: disable=too-many-return-statements, arguments-differ
return self.response_400(message=error.messages)
try:
changed_model = UpdateDashboardCommand(g.user, pk, item).run()
return self.response(200, id=changed_model.id, result=item)
response = self.response(200, id=changed_model.id, result=item)
except DashboardNotFoundError:
return self.response_404()
response = self.response_404()
except DashboardForbiddenError:
return self.response_403()
response = self.response_403()
except DashboardInvalidError as ex:
return self.response_422(message=ex.normalized_messages())
except DashboardUpdateFailedError as ex:
logger.error(
"Error updating model %s: %s", self.__class__.__name__, str(ex)
)
return self.response_422(message=str(ex))
response = self.response_422(message=str(ex))
return response

@expose("/<pk>", methods=["DELETE"])
@protect()
@safe
@statsd_metrics
def delete(self, pk: int) -> Response: # pylint: disable=arguments-differ
def delete(self, pk: int) -> Response:
"""Deletes a Dashboard
---
delete:
Expand Down Expand Up @@ -353,9 +352,7 @@ def delete(self, pk: int) -> Response: # pylint: disable=arguments-differ
@safe
@statsd_metrics
@rison(get_delete_ids_schema)
def bulk_delete(
self, **kwargs: Any
) -> Response: # pylint: disable=arguments-differ
def bulk_delete(self, **kwargs: Any) -> Response:
"""Delete bulk Dashboards
---
delete:
Expand Down