Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update saved query backend routing + add savedquery list #10922

Merged
merged 3 commits into from
Sep 17, 2020
Merged

feat: update saved query backend routing + add savedquery list #10922

merged 3 commits into from
Sep 17, 2020

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Sep 16, 2020 •
edited
Loading

SUMMARY

  • Add list route for Saved Queries, that serves React page when both ENABLE_REACT_CRUD_VIEWS and SIP_34_SAVED_QUERIES_UI feature flags are enabled
  • Add SavedQueryList skeleton with same SubMenu as other data pages and enable react routing functionality

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-09-16 at 2 35 56 PM

TEST PLAN

  • Add basic SavedQueryList unit tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

nytai
nytai reviewed Sep 16, 2020
View reviewed changes
superset-frontend/src/views/CRUD/data/common.ts Outdated Show resolved Hide resolved
superset/views/sql_lab.py Outdated Show resolved Hide resolved
nytai
nytai approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch merged commit 5623cd6 into apache:master Sep 17, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@riahk @auxten
feat: update saved query backend routing + add savedquery list (apach…
e833f9f 
…e#10922)

* Update saved query backend routing + add savedquery list

* add spec fileg

* add FE flag for SIP_34_SAVED_QUERIES_UI
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riahk @mistercrunch @nytai