Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint failures #10919

Closed
wants to merge 1 commit into from
Closed

fix: lint failures #10919

wants to merge 1 commit into from

Conversation

nytai
Copy link
Member

@nytai nytai commented Sep 16, 2020 •
edited
Loading

SUMMARY

There have been some recent changes to the linting rules. It seems #10799 merged without the checks including the latest linting rules.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

suddjian
suddjian approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nytai nytai mentioned this pull request Sep 16, 2020
Merged
6 tasks
@nytai
Copy link
Member Author

nytai commented Sep 16, 2020

already fixed by #10918

@nytai nytai closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@suddjian suddjian suddjian approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nytai @rusackas @suddjian