fix: superset alerting misc fixes #10891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
changed the title
bkyryliuk
force-pushed
the
bogdan/alerting_fixes
branch
3 times, most recently
from
cecfd46
to
8931466
Compare
Codecov Report
@@ Coverage Diff @@
## master #10891 +/- ##
==========================================
+ Coverage 59.15% 59.32% +0.17%
==========================================
Files 778 778
Lines 37123 37103 -20
Branches 3310 3310
==========================================
+ Hits 21959 22013 +54
+ Misses 14973 14904 -69
+ Partials 191 186 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bkyryliuk
changed the title
|
Let's get some tests around these fixes. |
bkyryliuk
force-pushed
the
bogdan/alerting_fixes
branch
from
8931466
to
f243e99
Compare
good reminder :) added the test |
mistercrunch
added a commit
that referenced
this pull request
Oct 2, 2020
This reverts commit c3f1720.
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Superset alerting misc fixes * Test 0 threshold Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
This reverts commit 7d09e4d.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN