Adding Dashboard toggle fullscreen button

[zhaoyongjie]

SUMMARY

Dashboard can recieve url parameter standalone toggle fullscreen mode or not, expose this function to Dashboard header dropdown

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

adding button in dashboard dropdown

Dashboard in fullscreen mode

TEST PLAN

Adding unit test to getDashboardUrl_spec.js

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-commenter]

Codecov Report

Merging #10840 into master will increase coverage by 0.02%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master   #10840      +/-   ##
==========================================
+ Coverage   65.57%   65.60%   +0.02%     
==========================================
  Files         809      809              
  Lines       38038    38216     +178     
  Branches     3561     3566       +5     
==========================================
+ Hits        24945    25072     +127     
- Misses      12987    13035      +48     
- Partials      106      109       +3     

Flag	Coverage Δ
#cypress	55.35% <50.00%> (-0.47%)	⬇️
#javascript	61.58% <58.33%> (-0.01%)	⬇️
#python	61.56% <ø> (+0.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...src/dashboard/components/HeaderActionsDropdown.jsx	68.88% <33.33%> (-5.48%)	⬇️
...set-frontend/src/dashboard/util/getDashboardUrl.js	88.88% <83.33%> (-11.12%)	⬇️
...et-frontend/src/SqlLab/reducers/getInitialState.js	33.33% <0.00%> (-16.67%)	⬇️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx	77.27% <0.00%> (-5.20%)	⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx	44.00% <0.00%> (-4.00%)	⬇️
...end/src/SqlLab/components/TemplateParamsEditor.jsx	88.57% <0.00%> (-2.86%)	⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js	60.25% <0.00%> (-2.36%)	⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js	37.75% <0.00%> (-1.66%)	⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx	52.12% <0.00%> (-1.22%)	⬇️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx	55.91% <0.00%> (-1.08%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136f90f...5e8aaf5. Read the comment docs.

[etr2460]

Could you attach a screenshot showing what the dashboard looks like after clicking the button?

[zhaoyongjie]

@etr2460 HI, I append a image to PR comment. thanks for you remind

[rusackas]

I think "standalone" is a better term... I would reserve "fullscreen" for some sort of Element.requestFullscreen() implementation...

Or, you could consider adding that functionality in this PR to make the functionality better fit the name.

[rusackas]

Actually, @zhaoyongjie I'm curious what your use case is here... do you want to share the link to others in "standalone mode" or is it that you want a version for TV/presentation purposes (i.e. "presentation mode")?

[ktmud]

FWIW, Tableau has a Presentation Mode on desktop app, but a Full Screen button on web.

They also removed the main menu on the dashboard page and replaced it with a back button.

Redash, on the other hand, replace the main menu with a sidebar everywhere. It'd be interesting to explore these nav patterns for Superset, too. But that's totally another topic.