Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): export dataset tests fails with presto #10818

Merged
merged 5 commits into from
Sep 10, 2020
Merged

fix(tests): export dataset tests fails with presto #10818

merged 5 commits into from
Sep 10, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Sep 9, 2020 •
edited
Loading

SUMMARY

Fix/Skip flaky test on presto for datasets export

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar marked this pull request as ready for review September 9, 2020 18:26
@mistercrunch mistercrunch merged commit e6a4808 into apache:master Sep 10, 2020
@dpgaspar dpgaspar deleted the fix/dataset-export-tests branch September 10, 2020 07:49
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@dpgaspar @auxten
fix(tests): export dataset tests fails with presto (apache#10818)
d1792cc 
* fix(tests): export dataset tests fails with presto

* debug

* debug

* skip dataset export test on presto

* add TODO on failing test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkyryliuk bkyryliuk bkyryliuk left review comments

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @mistercrunch @bkyryliuk