Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: layout flexiness #10681

Merged
merged 1 commit into from
Aug 26, 2020
Merged

fix: layout flexiness #10681

merged 1 commit into from
Aug 26, 2020

Conversation

rusackas
Copy link
Member

SUMMARY

@nytai @riahk I spotted some layout funkiness in the secondary menu bar on Master. Not sure when that slipped in, or if there's a better fix, but this seems to do the trick if it doesn't look too screwy to you.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TEST PLAN

👀

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from nytai August 26, 2020 06:59
@nytai
Copy link
Member

nytai commented Aug 26, 2020 •
edited
Loading

Lol, I just opened this #10682

@nytai nytai mentioned this pull request Aug 26, 2020
Merged
6 tasks
@rusackas rusackas merged commit a95e5c9 into apache:master Aug 26, 2020
@villebro villebro added the v0.38 label Sep 10, 2020
@villebro villebro deleted the submenu-layout-bugfix branch September 10, 2020 12:18
villebro pushed a commit to preset-io/superset that referenced this pull request Sep 11, 2020
@rusackas @villebro
fix: layout flexiness (apache#10681)
6e7593f
villebro pushed a commit that referenced this pull request Sep 11, 2020
@rusackas @villebro
fix: layout flexiness (#10681)
b85b277
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
@rusackas
fix: layout flexiness (apache#10681)
4515e22
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@rusackas @auxten
fix: layout flexiness (apache#10681)
ab9c62a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.38 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rusackas @nytai @mistercrunch @villebro