-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(thumbnails): missing field, logging and new config var #10562
Changes from all commits
e78c659
b3ba2ab
0f64bc6
8f6ba68
ad7310e
329a194
d453071
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -795,7 +795,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods | |
# chrome: | ||
# Requires: headless chrome | ||
# Limitations: unable to generate screenshots of elements | ||
EMAIL_REPORTS_WEBDRIVER = "firefox" | ||
WEBDRIVER_TYPE = "firefox" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. optional: change default to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would, but: https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#email-reports States that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe there are unresolved rendering errors on Firefox. Might not be applicable for thumbs, but worth mentioning. |
||
|
||
# Window size - this will impact the rendering of the data | ||
WEBDRIVER_WINDOW = {"dashboard": (1600, 2000), "slice": (3000, 1200)} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted and added a new field
thumbnail_url