feat: add favorite star to dashboard and chart lists #10510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
reviewed
Aug 4, 2020
nytai
reviewed
Aug 4, 2020
nytai
reviewed
Aug 4, 2020
| showTooltip?: boolean; | ||
| } | ||
|
|
||
| export default class FaveStar extends React.PureComponent<FaveStarProps> { |
nytai
approved these changes
Aug 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #10510 +/- ##
==========================================
+ Coverage 70.85% 71.00% +0.14%
==========================================
Files 604 605 +1
Lines 32400 32484 +84
Branches 3414 3438 +24
==========================================
+ Hits 22956 23064 +108
+ Misses 9332 9309 -23
+ Partials 112 111 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
reviewed
Aug 5, 2020
| @@ -0,0 +1,88 @@ | |||
| /** | |||
There was a problem hiding this comment.
nit (optional): for next time, let's use git mv when moving from jsx to tsx so that the file's git history stays attached to it. Now you're on the git blame for all the lines in the file :)
|
Impacts #8976 |
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
FaveStaricon and convert to TypeScriptBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Updated Cypress Tests for FaveStar
ADDITIONAL INFORMATION