fix: enforce mandatory chart name on save and edit #10482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@villebro pattern looks good. can we switch the button order of the Edit Chart Properties modal? Move Save to the right and Cancel to the left. sim to the Save Chart arrangement. can we also change the color of the active state for the Save button to #20A7C9? right now both active and disabled state are grey. |
|
@Steejay got it; I switched the order of the buttons. I think the colors are off in the animation, here's what they actually look like: |
|
@villebro great! thanks Ville. |
JasonD28
pushed a commit
to JasonD28/incubator-superset
that referenced
this pull request
Aug 3, 2020
* fix: show empty charts as empty in chart list view * migrate ControlLabel to FormLabel and enforce requred fields * lint * reorder buttons
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix: show empty charts as empty in chart list view * migrate ControlLabel to FormLabel and enforce requred fields * lint * reorder buttons
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently it is possible to save charts without names, causing confusion in the React CRUD list view. This PR changes the following:
ControlLabeltoFormLabelonSaveModal.tsxand add `required props to chart and dashboard and enforce required chart name on both "Save" and "Save & Go To Dashboard".BEFORE
AFTER
TEST PLAN
ADDITIONAL INFORMATION