Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Move security/manage navigation tabs into a settings dropdown #10439

Merged
merged 6 commits into from
Aug 27, 2020

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Jul 27, 2020

SUMMARY

  • Adds settings dropdown in top-right corner
  • Move Security/Manage menu options into settings dropdown
  • Move 'Import Dashboard(s)' to a button next to Bulk Select on Dashboards page

Note: This update is currently waiting on Superset to use the React navbar exclusively (which is not currently the case). See PR #10401 for the required change this depends on.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before (Also applies to FAB pages):
Screen Shot 2020-07-27 at 12 35 31 PM

After:
Screen Shot 2020-07-27 at 12 37 32 PM

Screen Shot 2020-07-27 at 12 55 19 PM

TEST PLAN

  • Added settings dropdown check to Menu_spec.jsx

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@mistercrunch
Copy link
Member

Is this abandoned? :(

@willbarrett
Copy link
Member

@riahk this needs another commit to re-trigger CI since the required checks have changed.

@nytai
Copy link
Member

nytai commented Aug 19, 2020

This is currently blocked by the pr that switches to using the react menu exclusively: #10401

That PR is blocked by my limited understanding of how the public role works (or doesn't work) in superset.

@riahk
Copy link
Contributor Author

riahk commented Aug 19, 2020

@mistercrunch I very much plan on getting this merged in! As Tai mentioned, we're waiting until superset is only using the react menu. I'll update the description to make this clearer and link the related PR 👍

@riahk riahk force-pushed the moriah/navbar-reorganization branch from cc18162 to fea4466 Compare August 19, 2020 17:21
@riahk riahk changed the title [WIP] style: Move security/manage navigation tabs into a settings dropdown style: Move security/manage navigation tabs into a settings dropdown Aug 19, 2020
@mistercrunch
Copy link
Member

#10401 has been merged, please rebase!

Also note that #10423 just got merged and may create conflicts with this. Let us know if you need help untangling some of this.

@riahk riahk force-pushed the moriah/navbar-reorganization branch from fea4466 to 4c397af Compare August 26, 2020 20:47
@codecov-commenter
Copy link

Codecov Report

Merging #10439 into master will decrease coverage by 4.22%.
The diff coverage is 37.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10439      +/-   ##
==========================================
- Coverage   64.43%   60.21%   -4.23%     
==========================================
  Files         785      785              
  Lines       36987    37030      +43     
  Branches     3530     3544      +14     
==========================================
- Hits        23833    22296    -1537     
- Misses      13045    14547    +1502     
- Partials      109      187      +78     
Flag Coverage Δ
#cypress ?
#javascript 60.85% <37.25%> (-0.07%) ⬇️
#python 59.82% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/components/Menu/MenuObject.tsx 86.66% <ø> (ø)
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 73.68% <50.00%> (-0.32%) ⬇️
superset-frontend/src/components/Menu/Menu.tsx 91.83% <90.00%> (-1.50%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95e5c9...4c397af. Read the comment docs.

@willbarrett
Copy link
Member

@riahk unfortunately this needs another rebase :(

@nytai nytai closed this Aug 26, 2020
@nytai nytai reopened this Aug 26, 2020
@nytai
Copy link
Member

nytai commented Aug 26, 2020

oops, sorry for closing. Also sorry for requiring another rabse, I just merged #10680

@riahk riahk force-pushed the moriah/navbar-reorganization branch from fc73f54 to 8ab4fba Compare August 26, 2020 23:32
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nytai nytai merged commit 8d94534 into apache:master Aug 27, 2020
@nytai nytai deleted the moriah/navbar-reorganization branch August 27, 2020 17:21
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants