-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Move security/manage navigation tabs into a settings dropdown #10439
Conversation
Is this abandoned? :( |
@riahk this needs another commit to re-trigger CI since the required checks have changed. |
This is currently blocked by the pr that switches to using the react menu exclusively: #10401 That PR is blocked by my limited understanding of how the public role works (or doesn't work) in superset. |
@mistercrunch I very much plan on getting this merged in! As Tai mentioned, we're waiting until superset is only using the react menu. I'll update the description to make this clearer and link the related PR 👍 |
cc18162
to
fea4466
Compare
fea4466
to
4c397af
Compare
Codecov Report
@@ Coverage Diff @@
## master #10439 +/- ##
==========================================
- Coverage 64.43% 60.21% -4.23%
==========================================
Files 785 785
Lines 36987 37030 +43
Branches 3530 3544 +14
==========================================
- Hits 23833 22296 -1537
- Misses 13045 14547 +1502
- Partials 109 187 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@riahk unfortunately this needs another rebase :( |
oops, sorry for closing. Also sorry for requiring another rabse, I just merged #10680 |
fc73f54
to
8ab4fba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
SUMMARY
Note: This update is currently waiting on Superset to use the React navbar exclusively (which is not currently the case). See PR #10401 for the required change this depends on.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before (Also applies to FAB pages):
After:
TEST PLAN
Menu_spec.jsx
ADDITIONAL INFORMATION