fix: dataset list filters bug #10398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,12 +274,15 @@ export default class TableSelector extends React.PureComponent { | |||
| } | |||
|
|
|||
| renderDatabaseSelect() { | |||
| const filters = this.props.formMode | |||
| ? '' | |||
| : 'filters:!((col:expose_in_sqllab,opr:eq,value:!t)),'; | |||
There was a problem hiding this comment.
Not sure what we've been doing so far around building API GET urls, but generally I would rather see rison.encode used against JS data structures instead of raw rison as many engs may not be familiar with rison
mistercrunch
approved these changes
Jul 23, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix dataset list filters * update database endpoint query params using rison encode
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION