Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): fixes openapi spec errors and adds a test to validate all spec #10393

Merged
merged 1 commit into from
Jul 23, 2020
Merged

fix(api): fixes openapi spec errors and adds a test to validate all spec #10393

merged 1 commit into from
Jul 23, 2020

Conversation

dpgaspar
Copy link
Member

SUMMARY

Fixes a couple of OpenAPI spec errors and introduces a test to validate the entire spec

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested a review from villebro July 22, 2020 14:39
villebro
villebro approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a very powerful validation tool 👍 I wonder if we should start listing our test dependencies in setup.py under tests_require?

@dpgaspar dpgaspar removed the request for review from john-bodley July 23, 2020 09:40
@dpgaspar
Copy link
Member Author

That's an interesting idea, it would be great if we could pip-compile the requirements-dev.txt also

@dpgaspar dpgaspar merged commit 98a11e7 into apache:master Jul 23, 2020
@dpgaspar dpgaspar deleted the fix/openapi-spec-ci branch July 23, 2020 09:43
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@dpgaspar @auxten
fix(api): fixes openapi spec errors and adds a test to validate all s…
db22bb3 
…pec (apache#10393)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @villebro @mistercrunch