fix: saving custom CSS correctly from dashboard editor

[rusackas]

SUMMARY

A fix was made to the save as modal that wasn't applied to the method called by the save as button after editing the custom CSS. This fixes the parameter name (which was changed to avoid a collision with Emotion props).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue: Fixes [dashboard] Custom CSS stopped working #10102
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[graceguo-supercat]

LGTM! thanks!

[PowerPlop]

When editing a dashboard and applying a custom css template, the change is not saved when pressing 'save changes' . You need to explicitly select 'Save As' + 'Overwrite' to keep the css change. Is this expected behavior?

[avicenteg]

Hello,

Altough it save the changes, when closing the dashboard and reopening it, it doesn't charge the custom CSS.

It is happening to anyone?

[avicenteg]

@rusackas @junlincc
Can you check my previous comment?
When I save my changes in the custom CSS, it is stored, but not charged when rendering again the dashboard.
For example:


I refresh the page and:

If I inspect the page, it is like if the css template were overwrited by the default css.

Do you have any clue of what can be happening?

[rusackas]

I haven't tried to replicate this exactly, but my guess would be that your CSS selector, and the one built into the column.less file are the same specificity, so they "tie" with the win going to the one that is loaded last by the browser. I might try to find some time to make sure that user-generated styles are loaded last (or feel free to help, if you're so inclined). For an easy way out, though, you probably just need to add to the selector to give it a slightly higher specificity. Even something silly like like adding body, e.g. body .grid-column > ... should do the trick.

[avicenteg]

@rusackas I'll try your advice. Also I'll check if I can find a way for loading the custom css first, if I find some solution I'll let you know.