Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Druid run_query executes phase 1 query with no limit #4208

Closed
michellethomas opened this issue Jan 12, 2018 · 1 comment · Fixed by #4581
Closed

Druid run_query executes phase 1 query with no limit #4208

michellethomas opened this issue Jan 12, 2018 · 1 comment · Fixed by #4581

Comments

@michellethomas
Copy link
Contributor

michellethomas commented Jan 12, 2018

In the druid run_query here a Phase 1 query is created if timeseries_limit == 0, but that can result in an incorrect query if the limit field is not present and there are parts of the Phase 2 query that are necessary (but don't get added).

This causes problems if a viz type does not have a limit but does require a phase 2 query or you remove the limit on a line chart.

@mistercrunch would you suggest having different logic for determining phase = 1 or pulling the necessary logic out of phase 2 and into phase 1?

@michellethomas
Copy link
Contributor Author

@mistercrunch any thoughts on this? If there's no timeseries limit we run a phase 1 query, which isn't always correct. Do you know why this step is necessary?

We are seeing group by line charts that should be 2 phase queries but the query only has a phase 1.

https://github.com/apache/incubator-superset/blob/master/superset/connectors/druid/models.py#L1072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant