Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Update metrics when columns are updated #1392

Closed
vera-liu opened this issue Oct 20, 2016 · 1 comment
Closed

[Feature] Update metrics when columns are updated #1392

vera-liu opened this issue Oct 20, 2016 · 1 comment
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@vera-liu
Copy link
Contributor

vera-liu commented Oct 20, 2016 •
edited
Loading

When initially loading a datasource, metrics are created automatically based on the data type.
When user goes in the edit metadata for the tables/columns, default metrics should be updated accordingly.
(i.e. when metadata is changed from 'Sum' to 'Count Distinct', sum metric should be removed)
Currently there's no option to change this when connecting a new table, the user has to go back and revise the table meta-data
@vera-liu vera-liu added the enhancement:request Enhancement request submitted by anyone from the community label Oct 20, 2016
@mistercrunch
Copy link
Member

Notice: this issue has been closed because it has been inactive for 549 days. Feel free to comment and request for this issue to be reopened.

@dpgaspar dpgaspar mentioned this issue Jul 3, 2020
Merged
6 tasks
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@zhaoyongjie @villebro
chore: hide rolling_periods and min_periods (apache#1392)
1c9c04a 
* chore: hide rolling_periods and min_periods

* Update packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@zhaoyongjie @villebro
chore: hide rolling_periods and min_periods (apache#1392)
6aa397b 
* chore: hide rolling_periods and min_periods

* Update packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@zhaoyongjie @villebro
chore: hide rolling_periods and min_periods (apache#1392)
57f3be7 
* chore: hide rolling_periods and min_periods

* Update packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@zhaoyongjie @villebro
chore: hide rolling_periods and min_periods (apache#1392)
de7b1f7 
* chore: hide rolling_periods and min_periods

* Update packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@snyk-bot snyk-bot mentioned this issue Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mistercrunch @vera-liu