Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeseries tooltips (on dashboard) not working on FF #1364

Closed
DaimonPl opened this issue Oct 17, 2016 · 15 comments
Closed

Timeseries tooltips (on dashboard) not working on FF #1364

DaimonPl opened this issue Oct 17, 2016 · 15 comments

Comments

@DaimonPl
Copy link

DaimonPl commented Oct 17, 2016

As in title, firefox does not display tooltips on time series when slice is used on dashboard. When slice is explored it works fine

Chrome displays tooltip in same scenario.

(0.11)

@xrmx
Copy link
Contributor

xrmx commented Oct 17, 2016

Is there any error on the browser console?

@DaimonPl
Copy link
Author

Nope, developer console is clear. Tooltips are working for parts like "explore" icon, but for timeseries itself nothing displays (in this case I'm using time series with time shift - not sure if it matters)

FF 49

@xrmx xrmx added the tooltips label Oct 19, 2016
@rumbin
Copy link
Contributor

rumbin commented Jan 31, 2017

Confirming this issue for Firefox 45.4.0.
I'm using Vivaldi browser as a workaround; however, FF-support is crucial in my eyes...

@rumbin
Copy link
Contributor

rumbin commented Jan 31, 2017

FF 51.0.1 64 Bit shows the same behavior.

@xrmx
Copy link
Contributor

xrmx commented Jan 31, 2017

@rumbin Everyone has his/her own priorities, if it's crucial then please go fix it :)

@rumbin
Copy link
Contributor

rumbin commented Jan 31, 2017

@xrmx I would, if I could. However, I guess that it's a js issue and this is far beyond my skills which consist of a tiny bit of python.

@ratb3rt
Copy link

ratb3rt commented Feb 14, 2017

FF 51.0.1 OSX 10.12 - the tooltips /do/ work on a dashboard, but they're functioning relative to the top left of the workspace. i.e. if the chart is positioned in the top left corner, everything looks fine - move it down and to the right, and the tooltips only appear when a) the cursor is over the chart, and b) the cursor is in the area that the chart would occupy if it was in the top left corner. The tooltips attach to the cursor ok, but the chart highlighting is offset by the chart offset. I don't think i'm explaining this well...
Edit: it looks like an ancient Firefox bug affecting D3: d3/d3#2771
Fix committed to nvd3 7 days ago: novus/nvd3#1953

Edit2: Tested with nvd3 master, and tooltips work perfectly in Firefox.

@pajachiet
Copy link

Thanks for your analysis @RichRadics

We still have this issue with recent version of Superset 0.18.5. How do you update nvd3 to latest version in Superset ?

@ratb3rt
Copy link

ratb3rt commented Sep 4, 2017

This was committed into superset in PR #3378 so should be fixed in the next release

@xrmx
Copy link
Contributor

xrmx commented Sep 4, 2017

@DaimonPl please close the issue, thanks!

@DaimonPl
Copy link
Author

DaimonPl commented Sep 8, 2017

I just checked this problem on Superset 0.19.1 and it still exists on Firefox

@pajachiet
Copy link

I confirm. I also checked with Superset 0.19.1 and it still exists on Firefox.

@xrmx
Copy link
Contributor

xrmx commented Sep 8, 2017

@DaimonPl the commit has been applied after 0.19.1 so test master or close the issue please.

@pajachiet no need for me too comments please.

@DaimonPl
Copy link
Author

Verified it's working fine with 0.20.0

@MahsaSeifikar
Copy link

I've recently built a dashboard on Superset 0.35.1 and this issue still exists on Firefox. How can I fix that?

zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
…1364)

* refactor: migrate timeseries_limit_metric to legacy_order_by

* improve coverage
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
…1364)

* refactor: migrate timeseries_limit_metric to legacy_order_by

* improve coverage
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
…1364)

* refactor: migrate timeseries_limit_metric to legacy_order_by

* improve coverage
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
…1364)

* refactor: migrate timeseries_limit_metric to legacy_order_by

* improve coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants