-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Grace Guo
committed
Jun 6, 2018
1 parent
6d3303a
commit f37800c
Showing
5 changed files
with
215 additions
and
45 deletions.
There are no files selected for viewing
116 changes: 116 additions & 0 deletions
116
superset/assets/spec/javascripts/dashboard/util/findFirstParentContainer_spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
import { describe, it } from 'mocha'; | ||
import { expect } from 'chai'; | ||
|
||
import findFirstParentContainerId from '../../../../src/dashboard/util/findFirstParentContainer'; | ||
import { | ||
DASHBOARD_GRID_ID, | ||
DASHBOARD_ROOT_ID, | ||
} from '../../../../src/dashboard/util/constants'; | ||
|
||
describe('findFirstParentContainer', () => { | ||
const mockGridLayout = { | ||
DASHBOARD_VERSION_KEY: 'v2', | ||
DASHBOARD_ROOT_ID: { | ||
type: 'DASHBOARD_ROOT_TYPE', | ||
id: 'DASHBOARD_ROOT_ID', | ||
children: ['DASHBOARD_GRID_ID'], | ||
}, | ||
DASHBOARD_GRID_ID: { | ||
type: 'DASHBOARD_GRID_TYPE', | ||
id: 'DASHBOARD_GRID_ID', | ||
children: ['DASHBOARD_ROW_TYPE-Bk45URrlQ'], | ||
}, | ||
'DASHBOARD_ROW_TYPE-Bk45URrlQ': { | ||
type: 'DASHBOARD_ROW_TYPE', | ||
id: 'DASHBOARD_ROW_TYPE-Bk45URrlQ', | ||
children: ['DASHBOARD_CHART_TYPE-ryxVc8RHlX'], | ||
}, | ||
'DASHBOARD_CHART_TYPE-ryxVc8RHlX': { | ||
type: 'DASHBOARD_CHART_TYPE', | ||
id: 'DASHBOARD_CHART_TYPE-ryxVc8RHlX', | ||
children: [], | ||
}, | ||
DASHBOARD_HEADER_ID: { | ||
id: 'DASHBOARD_HEADER_ID', | ||
type: 'DASHBOARD_HEADER_TYPE', | ||
}, | ||
}; | ||
const mockTabsLayout = { | ||
'DASHBOARD_CHART_TYPE-S1gilYABe7': { | ||
children: [], | ||
id: 'DASHBOARD_CHART_TYPE-S1gilYABe7', | ||
type: 'DASHBOARD_CHART_TYPE', | ||
}, | ||
'DASHBOARD_CHART_TYPE-SJli5K0HlQ': { | ||
children: [], | ||
id: 'DASHBOARD_CHART_TYPE-SJli5K0HlQ', | ||
type: 'DASHBOARD_CHART_TYPE', | ||
}, | ||
DASHBOARD_GRID_ID: { | ||
children: [], | ||
id: 'DASHBOARD_GRID_ID', | ||
type: 'DASHBOARD_GRID_TYPE', | ||
}, | ||
DASHBOARD_HEADER_ID: { | ||
id: 'DASHBOARD_HEADER_ID', | ||
type: 'DASHBOARD_HEADER_TYPE', | ||
}, | ||
DASHBOARD_ROOT_ID: { | ||
children: ['DASHBOARD_TABS_TYPE-SkgJ5t0Bem'], | ||
id: 'DASHBOARD_ROOT_ID', | ||
type: 'DASHBOARD_ROOT_TYPE', | ||
}, | ||
'DASHBOARD_ROW_TYPE-S1B8-JLgX': { | ||
children: ['DASHBOARD_CHART_TYPE-SJli5K0HlQ'], | ||
id: 'DASHBOARD_ROW_TYPE-S1B8-JLgX', | ||
type: 'DASHBOARD_ROW_TYPE', | ||
}, | ||
'DASHBOARD_ROW_TYPE-S1bUb1Ilm': { | ||
children: ['DASHBOARD_CHART_TYPE-S1gilYABe7'], | ||
id: 'DASHBOARD_ROW_TYPE-S1bUb1Ilm', | ||
type: 'DASHBOARD_ROW_TYPE', | ||
}, | ||
'DASHBOARD_TABS_TYPE-ByeLSWyLe7': { | ||
children: ['DASHBOARD_TAB_TYPE-BJbLSZ1UeQ'], | ||
id: 'DASHBOARD_TABS_TYPE-ByeLSWyLe7', | ||
type: 'DASHBOARD_TABS_TYPE', | ||
}, | ||
'DASHBOARD_TABS_TYPE-SkgJ5t0Bem': { | ||
children: [ | ||
'DASHBOARD_TAB_TYPE-HkWJcFCHxQ', | ||
'DASHBOARD_TAB_TYPE-ByDBbkLlQ', | ||
], | ||
id: 'DASHBOARD_TABS_TYPE-SkgJ5t0Bem', | ||
meta: {}, | ||
type: 'DASHBOARD_TABS_TYPE', | ||
}, | ||
'DASHBOARD_TAB_TYPE-BJbLSZ1UeQ': { | ||
children: ['DASHBOARD_ROW_TYPE-S1bUb1Ilm'], | ||
id: 'DASHBOARD_TAB_TYPE-BJbLSZ1UeQ', | ||
type: 'DASHBOARD_TAB_TYPE', | ||
}, | ||
'DASHBOARD_TAB_TYPE-ByDBbkLlQ': { | ||
children: ['DASHBOARD_ROW_TYPE-S1B8-JLgX'], | ||
id: 'DASHBOARD_TAB_TYPE-ByDBbkLlQ', | ||
type: 'DASHBOARD_TAB_TYPE', | ||
}, | ||
'DASHBOARD_TAB_TYPE-HkWJcFCHxQ': { | ||
children: ['DASHBOARD_TABS_TYPE-ByeLSWyLe7'], | ||
id: 'DASHBOARD_TAB_TYPE-HkWJcFCHxQ', | ||
type: 'DASHBOARD_TAB_TYPE', | ||
}, | ||
DASHBOARD_VERSION_KEY: 'v2', | ||
}; | ||
|
||
it('should return grid root', () => { | ||
expect(findFirstParentContainerId(mockGridLayout)).to.equal( | ||
DASHBOARD_GRID_ID, | ||
); | ||
}); | ||
|
||
it('should return first tab', () => { | ||
const tabsId = mockTabsLayout[DASHBOARD_ROOT_ID].children[0]; | ||
const firstTabId = mockTabsLayout[tabsId].children[0]; | ||
expect(findFirstParentContainerId(mockTabsLayout)).to.equal(firstTabId); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
superset/assets/src/dashboard/util/findFirstParentContainer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { TABS_TYPE } from './componentTypes'; | ||
import { DASHBOARD_ROOT_ID } from './constants'; | ||
|
||
export default function(layout = {}) { | ||
// DASHBOARD_GRID_TYPE or TABS_TYPE? | ||
let parent = layout[DASHBOARD_ROOT_ID]; | ||
if ( | ||
parent && | ||
parent.children.length && | ||
layout[parent.children[0]].type === TABS_TYPE | ||
) { | ||
const tabs = layout[parent.children[0]]; | ||
parent = layout[tabs.children[0]]; | ||
} else { | ||
parent = layout[parent.children[0]]; | ||
} | ||
|
||
return parent.id; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { DASHBOARD_ROOT_TYPE, DASHBOARD_GRID_TYPE } from './componentTypes'; | ||
|
||
import { | ||
DASHBOARD_GRID_ID, | ||
DASHBOARD_ROOT_ID, | ||
DASHBOARD_VERSION_KEY, | ||
} from './constants'; | ||
|
||
export default function() { | ||
return { | ||
[DASHBOARD_VERSION_KEY]: 'v2', | ||
[DASHBOARD_ROOT_ID]: { | ||
type: DASHBOARD_ROOT_TYPE, | ||
id: DASHBOARD_ROOT_ID, | ||
children: [DASHBOARD_GRID_ID], | ||
}, | ||
[DASHBOARD_GRID_ID]: { | ||
type: DASHBOARD_GRID_TYPE, | ||
id: DASHBOARD_GRID_ID, | ||
children: [], | ||
}, | ||
}; | ||
} |