fix: disable text reports for now (#16257)

* fix: disable text reports for now * Update tests
apache · Aug 16, 2021 · ee9a384 · ee9a384
1 parent 542b864
commit ee9a384
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 28 deletions.
diff --git a/superset-frontend/src/components/ReportModal/index.tsx b/superset-frontend/src/components/ReportModal/index.tsx
@@ -126,12 +126,7 @@ type ReportActionType =
     };
 
 const DEFAULT_NOTIFICATION_FORMAT = 'TEXT';
-const TEXT_BASED_VISUALIZATION_TYPES = [
-  'pivot_table',
-  'pivot_table_v2',
-  'table',
-  'paired_ttest',
-];
+const TEXT_BASED_VISUALIZATION_TYPES: string[] = [];
 
 const reportReducer = (
   state: Partial<ReportObject> | null,

diff --git a/superset-frontend/src/views/CRUD/alert/AlertReportModal.test.jsx b/superset-frontend/src/views/CRUD/alert/AlertReportModal.test.jsx
@@ -260,22 +260,6 @@ describe('AlertReportModal', () => {
     expect(wrapper.find(Radio)).toHaveLength(2);
   });
 
-  it('renders text option for text-based charts', async () => {
-    const props = {
-      ...mockedProps,
-      alert: mockData,
-    };
-    const textWrapper = await mountAndWait(props);
-
-    const chartOption = textWrapper.find('input[value="chart"]');
-    act(() => {
-      chartOption.props().onChange({ target: { value: 'chart' } });
-    });
-    await waitForComponentToPaint(textWrapper);
-
-    expect(textWrapper.find('input[value="TEXT"]')).toExist();
-  });
-
   it('renders input element for working timeout', () => {
     expect(wrapper.find('input[name="working_timeout"]')).toExist();
   });

diff --git a/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx b/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
@@ -52,12 +52,7 @@ import {
 
 const SELECT_PAGE_SIZE = 2000; // temporary fix for paginated query
 const TIMEOUT_MIN = 1;
-const TEXT_BASED_VISUALIZATION_TYPES = [
-  'pivot_table',
-  'pivot_table_v2',
-  'table',
-  'paired_ttest',
-];
+const TEXT_BASED_VISUALIZATION_TYPES: string[] = [];
 
 type SelectValue = {
   value: string;