Skip to content

Commit

Permalink
config: allow changing default options for writting csv
Browse files Browse the repository at this point in the history
  • Loading branch information
JulieRossi committed Sep 12, 2017
1 parent 3c0e85e commit dfed319
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions superset/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,11 @@
ENABLE_CORS = False
CORS_OPTIONS = {}

# CSV Options: key/value pairs that will be passed as argument to DataFrame.to_csv method
# note: index option should not be overridden
CSV_EXPORT = {
'encoding': 'utf-8',
}

# ---------------------------------------------------
# List of viz_types not allowed in your environment
Expand Down
4 changes: 2 additions & 2 deletions superset/views/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -2126,13 +2126,13 @@ def csv(self, client_id):
columns = [c['name'] for c in obj['columns']]
df = pd.DataFrame.from_records(obj['data'], columns=columns)
logging.info("Using pandas to convert to CSV")
csv = df.to_csv(index=False, encoding='utf-8')
csv = df.to_csv(index=False, **config.get('CSV_EXPORT'))
else:
logging.info("Running a query to turn into CSV")
sql = query.select_sql or query.executed_sql
df = query.database.get_df(sql, query.schema)
# TODO(bkyryliuk): add compression=gzip for big files.
csv = df.to_csv(index=False, encoding='utf-8')
csv = df.to_csv(index=False, **config.get('CSV_EXPORT'))
response = Response(csv, mimetype='text/csv')
response.headers['Content-Disposition'] = (
'attachment; filename={}.csv'.format(query.name))
Expand Down
2 changes: 1 addition & 1 deletion superset/viz.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def data(self):
def get_csv(self):
df = self.get_df()
include_index = not isinstance(df.index, pd.RangeIndex)
return df.to_csv(index=include_index, encoding="utf-8")
return df.to_csv(index=include_index, **config.get('CSV_EXPORT'))

def get_data(self, df):
return []
Expand Down

0 comments on commit dfed319

Please sign in to comment.