working file upload

apache · May 25, 2021 · bbd0208 · bbd0208
1 parent b6dfac3
commit bbd0208
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 12 deletions.
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
@@ -19,7 +19,7 @@
 import React, { FormEvent, useState } from 'react';
 import { SupersetTheme, JsonObject } from '@superset-ui/core';
 import { InputProps } from 'antd/lib/input';
-import { Input, Select, Upload, Button} from 'src/common/components';
+import { Input, Select, Upload, Button } from 'src/common/components';
 import ValidatedInput from 'src/components/Form/LabeledErrorBoundInput';
 import {
   StyledFormHeader,
@@ -42,7 +42,7 @@ interface FieldPropTypes {
   required: boolean;
   changeMethods: { onParametersChange: (value: any) => string } & {
     onChange: (value: any) => string;
-  };
+  } & { onParametersUploadFileChange: (value: any) => string };
   validationErrors: JsonObject | null;
   getValidation: () => void;
 }
@@ -59,27 +59,37 @@ const credentialsInfo = ({
       <Select
         defaultValue={'file'}
         style={{ width: '100%' }}
-        onChange={value => {
-          setUploadOption(value);
-        }}
+        onChange={option => setUploadOption(option)}
       >
         <Select value="file">Upload JSON file</Select>
         <Select value="paste">Copy and Paste JSON credentials</Select>
       </Select>
       {uploadOption === 'paste' ? (
         <div className="input-container" onChange={changeMethods.onChange}>
-          <Input name="encrypted_extra" rows={4}/>
+          <Input name="encrypted_extra" rows={4} />
         </div>
       ) : (
-        <Upload>
-          <Button>Click to Upload</Button>
-        </Upload>
+        <input
+          type="file"
+          onChange={async event => {
+            const file = event?.target?.files[0];
+            const credentials = JSON.parse(await file.text());
+            const encrypted_extra = JSON.stringify({
+              credentials_info: credentials,
+            });
+            changeMethods.onParametersUploadFileChange({
+              target: {
+                name: 'encrypted_extra',
+                value: encrypted_extra,
+              },
+            });
+          }}
+        />
       )}
     </>
   );
 };
 
-
 const hostField = ({
   required,
   changeMethods,
@@ -201,6 +211,7 @@ const DatabaseConnectionForm = ({
   dbModel: { name, parameters },
   onParametersChange,
   onChange,
+  onParametersUploadFileChange,
   validationErrors,
   getValidation,
 }: {
@@ -211,6 +222,9 @@ const DatabaseConnectionForm = ({
   onChange: (
     event: FormEvent<InputProps> | { target: HTMLInputElement },
   ) => void;
+  onParametersUploadFileChange: (
+    event: FormEvent<InputProps> | { target: HTMLInputElement },
+  ) => void;
   validationErrors: JsonObject | null;
   getValidation: () => void;
 }) => (
@@ -236,7 +250,11 @@ const DatabaseConnectionForm = ({
         ).map(field =>
           FORM_FIELD_MAP[field]({
             required: parameters.required.includes(field),
-            changeMethods: { onParametersChange, onChange },
+            changeMethods: {
+              onParametersChange,
+              onChange,
+              onParametersUploadFileChange,
+            },
             validationErrors,
             getValidation,
             key: field,

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
@@ -82,6 +82,7 @@ enum ActionType {
   parametersChange,
   reset,
   textChange,
+  parametersUploadFileChange,
 }
 
 interface DBReducerPayloadType {
@@ -99,7 +100,8 @@ type DBReducerActionType =
         | ActionType.textChange
         | ActionType.inputChange
         | ActionType.editorChange
-        | ActionType.parametersChange;
+        | ActionType.parametersChange
+        | ActionType.parametersUploadFileChange;
       payload: DBReducerPayloadType;
     }
   | {
@@ -170,6 +172,11 @@ function dbReducer(
       return {
         ...action.payload,
       };
+    case ActionType.parametersUploadFileChange:
+      return {
+        ...trimmedState,
+        [action.payload.name]: action.payload.value,
+      };
     case ActionType.reset:
     default:
       return {};
@@ -516,6 +523,16 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
                 value: target.value,
               })
             }
+            onParametersUploadFileChange={({
+              target,
+            }: {
+              target: HTMLInputElement;
+            }) =>
+              onChange(ActionType.parametersUploadFileChange, {
+                name: target.name,
+                value: target.value,
+              })
+            }
             getValidation={() => getValidation(db)}
             validationErrors={validationErrors}
           />